I suggest to refactor this code according to DRY Principle.
function AllByTag(){ // no actions }
AllByTag.setStyleDisplay = function(tagName,value){ var elements = document.getElementsByTagName(tagName); for(var i = 0; i < elements.length; i++){
elements[i].style.display = value; } }
I'm not familiar with that term, but your revisions intrigue me. The link you inserted didn't take me to any useful reference for the DRY principle, perhaps you typoed it?
// no actions
}
AllByTag.setStyleDisplay = function(tagName,value) {
var elements = document.getElementsByTagName(tagName);
for (var i = 0; i < elements.length; i++) {
elements[i].style.display = value;
}
}
AllByTag.show = function(tagName,dispType) {
AllByTag.setStyleDisplay(tagName, dispType ? dispType : 'inline');
}
AllByTag.hide = function(tagName,dispType) {
AllByTag.setStyleDisplay(tagName, 'none');
}
http://www.artima.com/intv/dry.html